fix(segments): warn before discarding an unsaved feature-specific seg…#7840
Open
narendraio wants to merge 1 commit into
Open
fix(segments): warn before discarding an unsaved feature-specific seg…#7840narendraio wants to merge 1 commit into
narendraio wants to merge 1 commit into
Conversation
…ment When creating a feature-specific segment from the feature panel, the segment is built in an inline drawer that is closed via the `onCancel` prop. That path bypasses the modal's intercept-close handler, so closing the drawer silently discarded any unsaved work. Route the drawer's cancel action through the existing `onClosing` guard so the user is asked to confirm before their unsaved changes are discarded. Closes Flagsmith#5368
|
@narendraio is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
the
front-end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (replace the blank template with this):
docs/if required so people know about the feature.Changes
Closes #5368
When creating a feature-specific segment from the feature panel, the segment is
built in an inline drawer that is closed via the
onCancelprop. That pathbypasses the modal's intercept-close handler, so closing the drawer silently
discarded any unsaved work.
This routes the drawer's cancel action through the existing
onClosingguard,so the user is asked to confirm before their unsaved changes are discarded —
the same confirmation already used when closing the full segment modal.
How did you test this code?
Manually:
feature-specific segment.
drawer open, choosing Ok discards and closes it.
(no prompt).
Also ran
npm run typecheckandeslinton the changed file (no new errors).